add has_import_errors filter to Core API GET /dags endpoint by gyli · Pull Request #54563 · apache/airflow

gyli · 2025-08-15T21:55:53Z

Resolves #53536

pierrejeambrun

Nice, do you mind adding some basic tests related to this addition. There is already a parameterized test for that:
test_dags.py def test_get_dags.

Also can you update the similar private endpoint (+test), because the UI actually use the private API. (ui/dags get_dags endpoint)

dosubot · 2025-08-20T13:05:29Z

Related Documentation

No published documentation to review for changes on this repository.
Write your first living document

^{How did I do? Any feedback?}

jason810496

Thanks for the PR! Same comment as Pierre.

FYI, here is the UI route to add the filter as well, thanks!

https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py#L77

gyli · 2025-08-25T03:57:11Z

Thanks @pierrejeambrun and @jason810496 , PR updated.

rawwar · 2025-08-25T04:39:01Z

Copying the comment from the parent issue for reference:

About the question whether has_import_errors is helpful that @AryanK1511 raised above, I think it can still be helpful to filter the DAGs that have been successfully loaded at least once before. For those dags, they have records in dags table, and if they have any import error later, the has_import_errors field will also be updated correctly.

So I think it's still useful to create such filter. I also suggest to update any related doc,
to highlight the Import Errors filter only returns DAGs that have been successfully loaded before.

jason810496

So I think it's still useful to create such filter. I also suggest to update any related doc,
to highlight the Import Errors filter only returns DAGs that have been successfully loaded before.

Agree, after Add description field for filter_param_factory #54903 we can add description for query parameter with the following code suggestion.

airflow-core/src/airflow/api_fastapi/common/parameters.py

jason810496

Additionally, the conflict need to be resolved, thanks!

pierrejeambrun

NIce. Just one nit.

Good to merge once we rebased and solved conflicts.

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dags.py

gyli · 2025-09-04T03:24:48Z

Thanks @pierrejeambrun and @jason810496! I've addressed your comments, plz review again.

pierrejeambrun

Thanks

…4563) * add has_import_errors filter * add unit tests * update test * add description * Update airflow-core/src/airflow/api_fastapi/common/parameters.py Change DAGs to Dags Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> * empty commit * Change DAGs to dags * Change DAGs to dags --------- Co-authored-by: Guangyang Li <mail@guangyangli.com> Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>

(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1) ## New Features: - Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614)) - Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563)) - Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882)) - Implement pattern search for event log endpoint ([#55114](apache/airflow#55114)) - Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263)) - Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302)) - Add `try_number` as filter to task instances ([#54695](apache/airflow#54695)) - Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049)) - Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004)) - Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652)) - Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408)) - Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177)) - Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437)) - Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738)) - Expose DAG parsing duration in the API ([#54752](apache/airflow#54752)) ## New API Endpoints: - Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776)) - Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920)) - Add TI bulk actions endpoint ([#50443](apache/airflow#50443)) - Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657)) ## Deprecations: - Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150)) ## Bug Fixes: - Fix dag import error modal pagination ([#55719](apache/airflow#55719))

add has_import_errors filter

1c4c287

boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Aug 15, 2025

pierrejeambrun reviewed Aug 20, 2025

View reviewed changes

pierrejeambrun marked this pull request as ready for review August 20, 2025 13:05

pierrejeambrun requested review from bbovenzi, bugraoz93, ephraimbuddy, jason810496, jscheffl, rawwar, ryanahamilton and shubhamraj-git as code owners August 20, 2025 13:05

jason810496 reviewed Aug 23, 2025

View reviewed changes

Guangyang Li added 2 commits August 24, 2025 23:40

merge main

865740e

add unit tests

9eea221

jason810496 mentioned this pull request Aug 25, 2025

Add description field for filter_param_factory #54903

Merged

jason810496 reviewed Aug 25, 2025

View reviewed changes

airflow-core/src/airflow/api_fastapi/common/parameters.py Show resolved Hide resolved

merge main

83a84b7

gyli requested review from jason810496 and pierrejeambrun September 2, 2025 03:57

jason810496 reviewed Sep 3, 2025

View reviewed changes

pierrejeambrun approved these changes Sep 3, 2025

View reviewed changes

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dags.py Outdated Show resolved Hide resolved

Guangyang Li added 3 commits September 3, 2025 23:09

merge main

37eddff

update test

dc2a2e8

add description

4b8bdb5

Guangyang Li added 3 commits September 4, 2025 16:11

empty commit

e63f20d

Change DAGs to dags

4573f09

Change DAGs to dags

bf30e03

jason810496 approved these changes Sep 5, 2025

View reviewed changes

Merge branch 'main' into add_has_import_errors

cefa371

pierrejeambrun approved these changes Sep 5, 2025

View reviewed changes

pierrejeambrun merged commit d1eeb83 into apache:main Sep 5, 2025
107 checks passed

gyli deleted the add_has_import_errors branch September 5, 2025 15:41

kaxil mentioned this pull request Oct 22, 2025

Update Python Client to 3.1.0 apache/airflow-client-python#138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add has_import_errors filter to Core API GET /dags endpoint#54563

add has_import_errors filter to Core API GET /dags endpoint#54563
pierrejeambrun merged 13 commits intoapache:mainfrom
gyli:add_has_import_errors

gyli commented Aug 15, 2025

Uh oh!

pierrejeambrun left a comment •

edited

Loading

Uh oh!

dosubot bot commented Aug 20, 2025

Uh oh!

jason810496 left a comment

Uh oh!

gyli commented Aug 25, 2025

Uh oh!

rawwar commented Aug 25, 2025

Uh oh!

jason810496 left a comment

Uh oh!

Uh oh!

jason810496 left a comment

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

gyli commented Sep 4, 2025

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gyli commented Aug 15, 2025

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dosubot bot commented Aug 20, 2025

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

gyli commented Aug 25, 2025

Uh oh!

rawwar commented Aug 25, 2025

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gyli commented Sep 4, 2025

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pierrejeambrun left a comment •

edited

Loading